From a4c4b6b15838408a9d84ba81467ce6ebb5e2ea41 Mon Sep 17 00:00:00 2001 From: Danyal Faheem Date: Thu, 10 Apr 2025 11:09:53 +0500 Subject: [PATCH] fix: remove deprecated filter_scopes from import_dashboard script (#66) Reference issue: https://github.com/overhangio/tutor-cairn/pull/53/files\#r2034772248 Filter_scopes have been deprecated as of Superset 4.0.0 We have also migrated away from filter box to native filters as of #53. --- ..._danyal.faheem_fix_breaking_dashboard_import.md | 1 + .../cairn/build/cairn-superset/cairn/ctl.py | 14 -------------- 2 files changed, 1 insertion(+), 14 deletions(-) create mode 100644 changelog.d/20250409_153019_danyal.faheem_fix_breaking_dashboard_import.md diff --git a/changelog.d/20250409_153019_danyal.faheem_fix_breaking_dashboard_import.md b/changelog.d/20250409_153019_danyal.faheem_fix_breaking_dashboard_import.md new file mode 100644 index 0000000..3e68651 --- /dev/null +++ b/changelog.d/20250409_153019_danyal.faheem_fix_breaking_dashboard_import.md @@ -0,0 +1 @@ +- [Bugfix] Remove deprecated filter_scopes from import_dashboard script. (by @Danyal-Faheem) \ No newline at end of file diff --git a/tutorcairn/templates/cairn/build/cairn-superset/cairn/ctl.py b/tutorcairn/templates/cairn/build/cairn-superset/cairn/ctl.py index 4f5bf48..e1267d9 100644 --- a/tutorcairn/templates/cairn/build/cairn-superset/cairn/ctl.py +++ b/tutorcairn/templates/cairn/build/cairn-superset/cairn/ctl.py @@ -229,20 +229,6 @@ def import_dashboard(data, user, database): # Update filter mapping metadata = json.loads(dashboard.json_metadata) - new_filter_scopes = {} - for old_slice_id, filter_scope in metadata["filter_scopes"].items(): - new_filter_scope = {} - for filter_name, properties in filter_scope.items(): - properties["immune"] = [ - old_to_new_slice_id_map[old_immune_id] - for old_immune_id in properties["immune"] - ] - new_filter_scope[filter_name] = properties - # Note that filter scope keys are str, not int - new_filter_scopes[ - str(old_to_new_slice_id_map[int(old_slice_id)]) - ] = new_filter_scope - metadata["filter_scopes"] = new_filter_scopes dashboard.json_metadata = json.dumps(metadata) # Load dashboard