Linked Epic: https://github.com/overhangio/tutor/issues/1251
Some new rules that have been added are:
I: sort imports
N: check for pep8-naming standards
W292: check for missing extra line at EOF
Some of our lines, particularly in config, break the 88 character line length limit. For that, we add a # noqa: E501 to let ruff know to ignore the rule for that line
* test: python package distribution build when running make test
Pushing to pypi would occasionally fail because of breaking distribution build.
We verify the build in the github CI now so that we can mitigate those errors later on.
Superset was running on 2247 port in dev mode and on 8000 in local mode
We now make this consistent so that superset runs on 2247 in both local and dev
* fix: don't add cairn-postgresql as a dependency when CAIRN_RUN_POSTGRESQL is false
* fix: don't manage cairn-clickhouse permissions CAIRN_RUN_CLICKHOUSE is false
* fix: add missing CAIRN_POSTGRESQL_HOST and CAIRN_POSTGRESQL_PORT settings to allow usage with external postgresql DBs
With the latest Docker upgrade, we got the following warnings during
build:
FromAsCasing: 'as' and 'FROM' keywords' casing do not match
LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
pkg_resources is a package that is unavailable in python 3.12, unless
setuptools is explicitely installed. Turns out, there are replacement
functions coming from importlib_resources, which can be obtained from
the importlib-resources pypi package. This package will be installed
with tutor starting from 17.0.2.
When running `do cairn-createuser`, the created db did not have the
right name. If the user had been created earlier with SSO, then the
Clickhouse DB did not exist.
This upgrade includes SSO login. Finally! We can now login to Superset
via the LMS. Thanks to OARS for providing the base security manager
implementation!
