From fcffe6f3edf21f256026d2bce6b98d7655640030 Mon Sep 17 00:00:00 2001 From: Jhony Avella Date: Mon, 31 Jul 2023 08:34:52 -0500 Subject: [PATCH] chore: remove notes permissions container. (#24) chore: remove notes permissions container There is now a single "permissions" container that makes all permission changes in Tutor core --- ...75900_jhony.avella_remove_permissions_container.md | 1 + .../patches/local-docker-compose-permissions-command | 1 + .../patches/local-docker-compose-permissions-volumes | 1 + tutornotes/patches/local-docker-compose-services | 11 +---------- 4 files changed, 4 insertions(+), 10 deletions(-) create mode 100644 changelog.d/20230731_075900_jhony.avella_remove_permissions_container.md create mode 100644 tutornotes/patches/local-docker-compose-permissions-command create mode 100644 tutornotes/patches/local-docker-compose-permissions-volumes diff --git a/changelog.d/20230731_075900_jhony.avella_remove_permissions_container.md b/changelog.d/20230731_075900_jhony.avella_remove_permissions_container.md new file mode 100644 index 0000000..99a9008 --- /dev/null +++ b/changelog.d/20230731_075900_jhony.avella_remove_permissions_container.md @@ -0,0 +1 @@ +- [Improvement] Removing the notes permissions container in favor of a global single permissions container. (by @jfavellar90) diff --git a/tutornotes/patches/local-docker-compose-permissions-command b/tutornotes/patches/local-docker-compose-permissions-command new file mode 100644 index 0000000..cd2f8bc --- /dev/null +++ b/tutornotes/patches/local-docker-compose-permissions-command @@ -0,0 +1 @@ +setowner 1000 /mounts/notes diff --git a/tutornotes/patches/local-docker-compose-permissions-volumes b/tutornotes/patches/local-docker-compose-permissions-volumes new file mode 100644 index 0000000..81daf14 --- /dev/null +++ b/tutornotes/patches/local-docker-compose-permissions-volumes @@ -0,0 +1 @@ +- ../../data/notes:/mounts/notes diff --git a/tutornotes/patches/local-docker-compose-services b/tutornotes/patches/local-docker-compose-services index 7c1bd59..e55c40e 100644 --- a/tutornotes/patches/local-docker-compose-services +++ b/tutornotes/patches/local-docker-compose-services @@ -7,13 +7,4 @@ notes: - ../plugins/notes/apps/settings/tutor.py:/app/edx-notes-api/notesserver/settings/tutor.py:ro - ../../data/notes:/app/data restart: unless-stopped - depends_on: - - notes-permissions - {% if RUN_MYSQL %}- mysql{% endif %} - -notes-permissions: - image: {{ DOCKER_IMAGE_PERMISSIONS }} - command: ["1000", "/app/notes"] - restart: on-failure - volumes: - - ../../data/notes:/app/notes + depends_on: {{ [("mysql", RUN_MYSQL)]|list_if }}