chore: addressing comments

This commit is contained in:
jfavellar90 2023-11-21 06:46:41 -05:00 committed by Régis Behmo
parent 8703186cef
commit 7f09751e8f
6 changed files with 19 additions and 11 deletions

View File

@ -19,3 +19,13 @@ instructions, because git commits are used to generate release notes:
<!-- scriv-insert-here --> <!-- scriv-insert-here -->
<a id='changelog-17.0.0'></a>
## v17.0.0 (2023-12-09)
- 💥 [Feature] Upgrade to Quince (by @jfavellar90).
- [Improvement] Add a scriv-compliant changelog. (by @regisb)
- [Improvement] Removing the xqueue permissions container in favor of a global single permissions container. (by @jfavellar90)
- [Bugfix] Fix "Error: service "xqueue-job" depends on undefined service mysql: invalid compose project" - add conditional statement to check whether the mysql service is enabled or if the user is using an external mysql instance. (by @ravikhetani)
- [Improvement] Added Typing to code, Makefile and test action to the repository and formatted code with Black and isort. (by @CodeWithEmad)

View File

@ -1 +0,0 @@
- [Improvement] Add a scriv-compliant changelog. (by @regisb)

View File

@ -1 +0,0 @@
- [Improvement] Removing the xqueue permissions container in favor of a global single permissions container. (by @jfavellar90)

View File

@ -1 +0,0 @@
- [Bugfix] Fix "Error: service "xqueue-job" depends on undefined service mysql: invalid compose project" - add conditional statement to check whether the mysql service is enabled or if the user is using an external mysql instance. (by @ravikhetani)

View File

@ -1 +0,0 @@
- [Improvement] Added Typing to code, Makefile and test action to the repository and formatted code with Black and isort. (by @CodeWithEmad)

View File

@ -1,10 +1,10 @@
{% if is_buildkit_enabled() %}# syntax=docker/dockerfile:1.4{% endif %} # syntax=docker/dockerfile:1.4
###### Minimal image with base system requirements for most stages ###### ###### Minimal image with base system requirements for most stages ######
FROM docker.io/ubuntu:20.04 as minimal FROM docker.io/ubuntu:20.04 as minimal
ARG DEBIAN_FRONTEND=noninteractive ARG DEBIAN_FRONTEND=noninteractive
RUN {% if is_buildkit_enabled() %}--mount=type=cache,target=/var/cache/apt,sharing=locked \ RUN --mount=type=cache,target=/var/cache/apt,sharing=locked \
--mount=type=cache,target=/var/lib/apt,sharing=locked{% endif %} \ --mount=type=cache,target=/var/lib/apt,sharing=locked \
apt update && \ apt update && \
apt upgrade -y && \ apt upgrade -y && \
apt install -y \ apt install -y \
@ -27,10 +27,12 @@ WORKDIR /openedx/xqueue
###### Install python venv ###### ###### Install python venv ######
RUN python -m venv /openedx/venv RUN python -m venv /openedx/venv
ENV PATH /openedx/venv/bin:${PATH} ENV PATH /openedx/venv/bin:${PATH}
# https://pypi.org/project/setuptools/
RUN {% if is_buildkit_enabled() %}--mount=type=cache,target=/openedx/.cache/pip,sharing=shared {% endif %}pip install setuptools==68.2.2 pip==23.2.1. wheel==0.41.2 # https://pypi.org/project/pip/
RUN {% if is_buildkit_enabled() %}--mount=type=cache,target=/openedx/.cache/pip,sharing=shared {% endif %}pip install -r requirements.txt # https://pypi.org/project/wheel/
RUN {% if is_buildkit_enabled() %}--mount=type=cache,target=/openedx/.cache/pip,sharing=shared {% endif %}pip install uwsgi==2.0.22 RUN --mount=type=cache,target=/openedx/.cache/pip,sharing=shared pip install setuptools==68.2.2 pip==23.2.1. wheel==0.41.2
RUN --mount=type=cache,target=/openedx/.cache/pip,sharing=shared pip install -r requirements.txt
RUN --mount=type=cache,target=/openedx/.cache/pip,sharing=shared pip install uwsgi==2.0.22
RUN mkdir /openedx/data /openedx/data/media RUN mkdir /openedx/data /openedx/data/media